This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Patch [MinGW] FYI: #undef OUT (was Re: jdwp build failure)
- From: Mohan Embar <gnustuff at thisiscool dot com>
- To: java-patches at gcc dot gnu dot org
- Cc: Danny Smith <dannysmith at clear dot net dot nz>, Marco Trudel <mtrudel at gmx dot ch>
- Date: Thu, 22 Feb 2007 08:18:28 -0600
- Subject: Patch [MinGW] FYI: #undef OUT (was Re: jdwp build failure)
- Reply-to: gnustuff at thisiscool dot com
Hi All,
-->Mohan wrote:
>>> I had already tried that, but it didn't work. I had even put an
>>> #undef OUT in the offending .cc file with no luck. Still, if it
>>> only happens on Win32, it has to be a macro, right?.
>>> I've only made half-hearted attempts here.
Ouch. I guess I hadn't put the #undef OUT in the right place. Thanks
for catching this, Marco. And thanks for your insight, Danny.
-->Marco wrote:
>Also "OUT" is a common widespread word and might lead to conflicts in
>future too.
Yes, but we're doing this for other such macros in win32-thread.h already.
I've committed the following patch, which seems to unbreak the build.
Sorry I've been so distracted lately.
-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/
2007-02-22 Mohan Embar <gnustuff@thisiscool.com>
* include/win32-threads.h: Added #undef OUT.
Index: include/win32-threads.h
===================================================================
--- include/win32-threads.h (revision 122226)
+++ include/win32-threads.h (working copy)
@@ -227,5 +227,6 @@
#undef STRICT
#undef VOID
#undef TEXT
+#undef OUT
#endif /* __JV_WIN32_THREADS__ */