This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] JMTI Exception Events


Tom Tromey wrote:
"Kyle" == Kyle Galloway <kgallowa@redhat.com> writes:

Please use javaStyleNaming. I'm more a gnu-style person myself, but
we're stuck with that. (One of my little pet peeves is that the stack
trace stuff uses uppercase for the start of method names... weird and
somehow irritating.)

Kyle> So you want, postExceptionEvent instead of post_exception_event.


Yes please.

Kyle> What about the two native calls should they be sendEvent and
Kyle> checkCatch.

Ah, yes.

Kyle> Also do you want the variable names changed to throwMeth, catchLoc
Kyle> etc?

Short names are fine.  Variables I'm less picky about, it is mostly
method names that look weird when not java-style.

Kyle> And while I'm at it, should it be funtion() or function () in
Kyle> java files outside of classpath, I think I've seen both?.

Officially we use function() for calls.  I don't recall whether we
have an official stance on definitions.  There is a lot of
inconsistency here.

Kyle> I'm sorry to keep asking about/screwing this up but I find it
Kyle> can be a little confusing to know which conventions to use
Kyle> sometimes.

Yeah.  I thought there was a classpath style guideline somewhere,
maybe in classpath/doc.  ChangeLogs are described in the GNU coding
standards; if you're an info users they are already on your system...

Kyle> Other than these is this ok to go in?

Yes, thank you.
Changed and committed.

Thanks,
Kyle


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]