This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/JDWP] Implement more VMMethod methods

Tom Tromey wrote: 
Keith> Hmm. So why did jdwpVMInitCB require it? That's just a static function
Keith> in natVMVirtualMachine.cc. [That's what confused me about Marco's
Keith> problems with the VM_INIT patch last week.]

It is declared as JNICALL.  But I assume that was added to the
declaration at the same time as it was to the definition?  Anyway, it
should not need this AFAICS.

Ah, okay, I think I understand what was confusing me... I was defining the JVMTI callback. Since the callback is typedef'd using JNICALL, the actual callback implementation must use JNICALL, too.

In any case, I've committed the VMMethod patch with your changes.

Thanks,
Keith

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]