This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Implement JVMTI GetClassStatus


Tom Tromey wrote:

Keith> +      if (gcj::verifyClasses)
Keith> +	(*status_ptr) |= JVMTI_CLASS_STATUS_VERIFIED;

We've only verified the code if the state is >= JV_STATE_LINKED.

I've changed it to: 'state >= JV_STATE_LINKED'.


Keith> +      else if (state > JV_STATE_IN_PROGRESS)
Keith> +	(*status_ptr) |= JVMTI_CLASS_STATUS_INITIALIZED;

This test should probably just be 'state == JV_STATE_DONE'.

I've changed that.


JV_STATE_PHANTOM is weird, and you don't want to handle JV_STATE_ERROR
this way either.

What to do about JV_STATE_ERROR, then? Ignore it?


Keith


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]