This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: retracting my retraction [patch included]


Andrew Haley wrote:
Mohan Embar writes:
> Hi All,
> > >Sorry about the delay on reading this.
> >I finally read this whole thread.
> >
> >Adam> - GCJ="${target_noncanonical}-gcj -B`${PWDCMD-pwd}`/"
> >Adam> + GCJ="$built_gcc_dir/gcj -B$built_gcc_dir/"
> >
> >I think this patch is probably causing problems for Marco.
> >However I'm not certain.
> > Whoa. Did this actually get committed? In one of the follow-ups,
> I pointed out that this was wrong and Andrew came around and
> agreed with me. This hadn't gotten committed to the ecj branch
> at the time that I was working on an alternative patch.
> > OK. Looking at SVN, I see this has been committed. This is wrong
> for the reasons I mentioned in the followup and should be reverted:
> > http://gcc.gnu.org/ml/java-patches/2006-q4/msg00313.html


Go on, then.

Since this patch - generally breaks all canadian cross-compilations - this was pointed out already before committing - Andrew gave his ok I'd also go for reverting it. Mohan, would you do the honor?


thanks Marco


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]