This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [RFA/JDWP] VMVirtualMachine StringBuffer cleanup
- From: Andrew Haley <aph at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>, Java Patch List <java-patches at gcc dot gnu dot org>
- Date: Mon, 15 Jan 2007 19:35:51 +0000
- Subject: Re: [RFA/JDWP] VMVirtualMachine StringBuffer cleanup
- References: <4552294E.1070500@redhat.com> <45A6E7D2.2030306@redhat.com> <17831.31861.849673.389800@zebedee.pink>
Andrew Haley writes:
> Keith Seitz writes:
> > Post-merge ping.
> >
> > Keith
> >
> > Keith Seitz wrote:
> > > Hi,
> > >
> > > I've been meaning to cleanup a lot of the gnu/classpath/jdwp/nat*.cc
> > > files, and this is one of the things that made it onto my pet peeve list
> > > recently. The attached patch switches to the
> > > gnu.gcj.runtime.StringBuffer instead of the java.lang one.
> > >
> > > I've got some other little cleanups that I'll submit after this.
> > >
> > > Keith
> > >
> > > ChangeLog
> > > 2006-11-08 Keith Seitz <keiths@redhat.com>
> > >
> > > * gnu/classpath/jdwp/natVMVirtualMachine.cc (suspendThread): Use
> > > gnu.gcj.runtime.StringBuffer instead of java.lang.StringBuffer.
> > > (resumeThread): Likewise.
>
> Use java.lang.StringBuilder instead of gnu.gcj.runtime.StringBuffer.
> Patch approved with that change.
Forget that. Use gnu.gcj.runtime.StringBuffer if you wish.
Andrew.