This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch [ecj]: Fix cross-configury issues / compile ecj.jar for non-shared builds
- From: Mohan Embar <gnustuff at thisiscool dot com>
- To: Andrew Haley <aph at redhat dot com>
- Cc: java-patches at gcc dot gnu dot org, Adam Megacz <adam at megacz dot com>, tromey at redhat dot com
- Date: Thu, 07 Dec 2006 09:32:40 -0600
- Subject: Re: Patch [ecj]: Fix cross-configury issues / compile ecj.jar for non-shared builds
- Reply-to: gnustuff at thisiscool dot com
Hi Andrew,
>There are some very subtle details that are easy to miss: for example,
>a Thread.interrupt() followed by a park() does not block the thread
>because Thread.interrupt() always does an unpark(). This means that
>there is no race between Thread.interrupt() and park(); it doesn't
>matter in which order they occur. I think your proposed change might
>have broken that.
You're right. I hadn't completely understood the concept of permits when
I wrote that patch. Rereading the JavaDoc for LockSupport, I see that I
can't eliminate the call to unpark() in Thread.interrupt().
-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/