Re: Patch: FYI: fix classpath/23863

[Marco Trudel <mtrudel at gmx dot ch>]

Tom Tromey wrote:
> > > > > > "Marco" == Marco Trudel <mtrudel@gmx.ch> writes:
>
> Marco> The new function _calloc_r from your patch
> Marco> (http://gcc.gnu.org/ml/java-patches/2006-q2/msg00347.html) breaks
> Marco> compilation on cygwin.
>
> Thanks for trying this!

You're welcome...


> Marco> /cygdrive/d/marco/GCC/source/libjava/classpath/native/fdlibm/mprec.c:104:
> Marco> error: static declaration of 'calloc' follows non-static declaration
>
> I'd guess that cygwin declares _calloc_r in a header somewhere.
> I don't think we need to call this function '_calloc_r' in
> mprec... try the appended patch.  If it works for you I will check it in.

Yes, there's no need to call it that way. It's only used in mprec.c in 
the whole gcc source. Patch works, thanks for the fast reaction!


> Marco> /cygdrive/d/marco/GCC/source/libjava/classpath/native/fdlibm/mprec.c:105:
> Marco> error: expected identifier or '(' before '{' token
>
> Marco> I can fix the static error by remove the static specifier, but I have
> Marco> no idea what the second error could mean... Any ideas?
>
> A mysterious error like this usually means that there is some #define
> that makes the output look weird... I usually look at the 'gcc -E'
> output to see what the code looks like after preprocessing.

I'll try next time. Thanks for the tip.


> I suspect the patch may fix this error as well.

Yes :-)


Marco