This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: jvmti patch for mingw32

Mohan Embar wrote:
Hi Tom,

Mohan> Are the other broken places similar missing JNICALL declarations
Mohan> or other issues? If they are similar missing declarations, can you
Mohan> combine them into one patch? Thanks for looking into this. If you
Mohan> create a proper ChangeLog, I'll check this in if no one else does.


I'm doing a build here with that patch in place.  I also made that
function 'static'.  I'll commit when the build is done.

Thanks for this.

Marco: just for fun, if you want to redo the patch like I said
and either send it to me personally or post it to this list, I
or others can review it for correct form.

I think that won't be necessary. I will keep your comments as further references and ask on the next patch if everything is fine.


thanks
Marco

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]