This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] fix HPUX-PA build on posix.cc


Bryce McKinlay wrote:
Its probably cleaner just to drop the "const" in the _Jv_platform_dladdr() declaration. I can't see any reason for that.

Ok, after short discussion on irc I see the point now and changed the patch. Building right now.


If testing is ok can I commit to trunk?

Thanks,
Andreas


2006-07-04 Andreas Tobler <a.tobler@schweiz.ch>


	PR libgcj/28226:
	* include/posix.h (_Jv_platform_dladdr): Remove const qualifier.
	* include/win32.h (_Jv_platform_dladdr): Likewise.
	* posix.cc (_Jv_platform_dladdr): Likewise.
	* win32.cc (_Jv_platform_dladdr): Likewise.



Index: include/posix.h
===================================================================
--- include/posix.h	(revision 115180)
+++ include/posix.h	(working copy)
@@ -199,6 +199,6 @@
 
 // Given an address, determine the executable or shared object that defines
 // it and the nearest named symbol.
-extern int _Jv_platform_dladdr (const void *addr, _Jv_AddrInfo *info);
+extern int _Jv_platform_dladdr (void *addr, _Jv_AddrInfo *info);
 
 #endif /* __JV_POSIX_H__ */
Index: include/win32.h
===================================================================
--- include/win32.h	(revision 115180)
+++ include/win32.h	(working copy)
@@ -180,6 +180,6 @@
 
 // Given an address, determine the executable or shared object that defines
 // it and the nearest named symbol.
-extern int _Jv_platform_dladdr (const void *addr, _Jv_AddrInfo *info);
+extern int _Jv_platform_dladdr (void *addr, _Jv_AddrInfo *info);
 
 #endif /* __JV_WIN32_H__ */
Index: posix.cc
===================================================================
--- posix.cc	(revision 115180)
+++ posix.cc	(working copy)
@@ -213,7 +213,7 @@
 // defined symbol to that address.  Returns 0 if no object defines this
 // address.
 int
-_Jv_platform_dladdr (const void *addr, _Jv_AddrInfo *info)
+_Jv_platform_dladdr (void *addr, _Jv_AddrInfo *info)
 {
   int ret_val = 0;
 
Index: win32.cc
===================================================================
--- win32.cc	(revision 115180)
+++ win32.cc	(working copy)
@@ -463,7 +463,7 @@
 // defined symbol to that address.  Returns 0 if no object defines this
 // address.
 int
-_Jv_platform_dladdr (const void *addr, _Jv_AddrInfo *info)
+_Jv_platform_dladdr (void *addr, _Jv_AddrInfo *info)
 {
   // Since we do not have dladdr() on Windows, we use a trick involving
   // VirtualQuery() to find the module (EXE or DLL) that contains a given

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]