This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [MinGW] RFC/RFA: Get Partial Stack Traces on Windows

Ranjit Mathew wrote:
Andrew Haley wrote:
Ranjit Mathew writes:
> - - if ((void*)rfp < _esp || diff > 4 * 1024 || diff < 0)
> + if (((unsigned int)rfp & 0x00000003) != 0 || (void*)rfp < _esp
> > > Don't use unsigned int for a pointer; instead use > > int __attribute__((mode(pointer))). This is an int that is exactly the
> > same size as a pointer.
> > I was just following in the illustrious footsteps of Bryce. ;-)

Everything can be improved, y'know!

I was just kidding.

FWIW, I didn't write that (fallback_backtrace) code - it was just copied/moved from win32.cc. Actually, I think the old backtrace() in win32.cc can be deleted now.

Bryce

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]