Re: [MinGW] RFC/RFA: Get Partial Stack Traces on Windows

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Ranjit" == Ranjit Mathew <rmathew@gmail.com> writes:

Ranjit> Here's the third revision of this patch that implements Andrew's
Ranjit> suggestion. Since the other typedefs in javaprims.h seem to
Ranjit> omit the "_t" suffix, I've omitted it here as well.

Either is fine by me.  The comment helps, thanks.

Ranjit> By the way, the reason main() does not appear in the stack trace
Ranjit> is because it is called indirectly by call_main() in
Ranjit> "gnu/java/lang/natMainThread.cc". The generated code is something
Ranjit> like "CALL %8(%EBX)" instead of the normal "CALL xyz".

Weird.  We do this in at least one other place as well --
Class.newInstance.

Ranjit> +// Types to use when treating a pointer as an integer.  Similar to
Ranjit> +// intptr_t and uintptr_t in C99.
Ranjit> +typedef int _Jv_intptr __attribute__((__mode__(__pointer__)));
Ranjit> +typedef unsigned int _Jv_uintptr __attribute__((__mode__(__pointer__)));

I tend to think we just want one of these.  I couldn't think of a
situation where I'd need both.

Ranjit> OK to apply?

I'm going to defer to Bryce and/or Andrew on this one.

Tom