This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [MinGW] RFC/RFA: Get Partial Stack Traces on Windows


Tom Tromey writes:
 > >>>>> "Andrew" == Andrew Haley <aph@redhat.com> writes:
 > 
 > >> -      if ((void*)rfp < _esp || diff > 4 * 1024 || diff < 0)
 > >> +      if (((unsigned int)rfp & 0x00000003) != 0 || (void*)rfp < _esp
 > 
 > Andrew> Don't use unsigned int for a pointer; instead use 
 > Andrew> int __attribute__((mode(pointer))).  This is an int that is exactly the
 > Andrew> same size as a pointer.
 > 
 > Maybe we ought to add a _Jv_intptr_t typedef somewhere.

Mmm.  It's used in a few places.

Andrew.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]