Re: [RFA] Boehm GC support addition for debugging

[Bryce McKinlay <mckinlay at redhat dot com>]

Keith Seitz wrote:
> It turns out I lied when I said I was only going to stub the 
> _Jv_ThreadDebug* methods. I think I will submit them for approval, but 
> first I need to add two new functions the GC interface: one to suspend 
> threads and one to resume them. Is there a related doc patch that is 
> required for GC interface expansions? I don't see anything. Is there 
> another GC implementation in which I need to stub these methods?
nogc.cc should also be updated.

> I've ifdef'd out the code for this because I'm still awaiting word on 
> the latest revision of my Boehm GC external thread suspension patch.
>
> Keith
>
> ChangeLog
> 2006-06-19  Keith Seitz  <keiths@redhat.com>
>
>         * include/boehm-gc.h (_Jv_SuspendThread): Declare.
>         (_Jv_ResumeThread): Declare.
>         * boehm-gc.cc (_Jv_SuspnedThread): New function.
>         (_Jv_ResumeThread): New function.

OK, but please check in the Boehm GC patch at the same time and remove 
the #ifdef's. This is trunk we're talking about, and the thread 
suspension code is unlikely to break anything that currently works. If 
there are problems discovered with the thread suspension code, then we 
can just fix them in trunk.

Thanks,

Bryce