Re: Second ping: rewrite File.toCanonicalPath()

[Andrew Haley <aph at redhat dot com>]

Gary Benson writes:
 > Bryce McKinlay wrote:
 > > Gary Benson wrote:
 > > > A couple of months ago I posted a patch that rewrote
 > > > File.toCanonicalPath() on GNU/Posix systems in order
 > > > for FilePermission checks to work properly...
 > > 
 > > Sorry for the delay in reviewing this. This patch looks
 > > pretty good to me, but I think a few extra comments would
 > > help to make it more readable - could you add one to
 > > nextChunkSize explaining what the algorithm does?  Also,
 > > I think a comment in getCanonicalPath itself briefly
 > > explaining the approach and why it is necessary would be
 > > very helpful. A ChangeLog entry is needed as well.
 > > 
 > > Otherwise, OK - please go ahead and check it in to trunk
 > > with these changes (you can post the final patch to the
 > > list as an FYI).
 > 
 > I made the changes but don't have commit access.  Could
 > someone please commit the attached patch for me?

They could, but I suggest you apply for commit access.  You'll need it
if you're going to do much gcj security work.

http://gcc.gnu.org/svnwrite.html

Andrew.