Re: [patch] include/posix.h

[Andreas Tobler <toa at pop dot agri dot ch>]

Tom Tromey wrote:
> > > > > > "Andreas" == Andreas Tobler <toa@pop.agri.ch> writes:
>
> Andreas> We conflict with the gcj/javaprims.h and the Boolean.h when we compile
> Andreas> java/net/natVMNetworkInterfacePosix.cc
>
> Thanks.
>
> What if we handled this more directly and generated a Boolean.h that
> had the #undefs at the top?  I think that would work a bit better in
> more cases.  Otherwise we're dependent on the order of inclusion of
> our posix.h, system headers, and Boolean.h.

Well, this does not help if Boolean.h is included before such magic 
system headers which define TRUE and FALSE again.

In our case sys/rw_lock.h, the file where this (re)-definition happens, 
is included after Boolean.h, implicitely. So I tend to agree with Dave 
that the workaround he proposes is probably the best one in regard of 
effort and gain.

Thanks,
Andreas