Re: Permissions not checked in BC-ABI code

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Andrew" == Andrew Haley <aph@redhat.com> writes:

Andrew> We're not checking permissions correctly when linking BC-ABI method
Andrew> calls.  This allows access to private methods, etc.  

Ouch.

It's well past time we had a vm-level test suite... :(

Andrew> This is going to require some fairly extended testing to make sure it
Andrew> doesn't break anything, which I'll do before I check it in.

The patch looks reasonable to me.  I suspect, unfortunately, that
we're going to want to defer the IllegalAccessError here.

Andrew> It seems that this same loop up the sueprclass chain calling
Andrew> search_method_in_class() is used several times in _Jv_Linker, so I
Andrew> might factor that out and give it a name, but that would obfuscate
Andrew> this patch.

Thanks.

Tom