This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [RFA] _Jv_CompileMethod
- From: Keith Seitz <keiths at redhat dot com>
- To: Bryce McKinlay <mckinlay at redhat dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: Wed, 18 Jan 2006 13:44:11 -0800
- Subject: Re: [RFA] _Jv_CompileMethod
- References: <43CE9FE3.4070401@redhat.com> <43CEB242.9070702@redhat.com>
Bryce McKinlay wrote:
Why call _Jv_InterpMethod::run() instead of _Jv_InterpMethod::compile()
directly? That would make more logical sense I think, and the
compile_mutex locking could be moved into compile() in order to handle
the case where a request to compile were made simultaneously by both the
interpreter and the JDWP.
Tom's already answered that. I'll mention that I tried REALLY hard to do
what you mention in your follow-up (which I just saw), but it's
incredibly, frustratingly difficult. And very ugly. Very, very ugly.
Also, for the current patch, it looks like the "When args is NULL, don't
run anything -- just compile it." comment is on the wrong method.
Yes, you are right. Grr. I've fixed that in the patch I'm checking in.
Do you have commit access for gcc/libgcj?
I believe I still do, but if the commit fails, I'll let you know! ;-)
Keith