This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix powerpc libffi (take 2)

David Edelsohn wrote:
2006-01-18 Jakub Jelinek <jakub@redhat.com>

	* src/powerpc/sysv.S (smst_two_register): Don't call __ashldi3, instead
	do the shifting inline.
	* src/powerpc/ppc_closure.S (ffi_closure_SYSV): Don't compute %r5
	shift count unconditionally.  Simplify load sequences for 1, 2, 3, 4
	and 8 byte structs, for the remaining struct sizes don't call __lshrdi3,
	instead do the shifting inline.

Inlining the shifts instead of calling the functions is good.  Sorry for
not considering that.  If you and Andreas are satisfied with the patch
now, it's fine with me.

Fine with me too. I only tested the libffi suite. No further testing possible atm, but I do not expect other troubles.

Thanks for made me learning some more fine details!

Andreas

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]