This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Patch: Fix stacktrace line numbers for mipsel-linux.


Due to my hacks to get the mips port working several years ago, the new stacktrace infrastructure does not print line numbers in stack traces.

This patch removes enough of the hacks so that line numbers are once again produced.

The disable_dladdr was used only by the mips port for the purpose of working around bugs in glibc 2.2.[45]. Since I have moved up in the world and am now using a (mostly) working glibc-2.3.3, and I would expect that most users of gcc-4.1 will not be using older broken glibcs, this should be a win. Many of the users of mipsel-linux are using cross compilers so a configure check for this breakage is not really possible.


Currently building/testing on i686-pc-linux-gnu(FC3) and mipsel-linux cross compiler.


OK to commit to 4.1 and trunk if no regressions?


2006-01-17 David Daney <ddaney@avtrex.com>


	* configure.host (disable_dladdr): Remove variable and its
	documentation.
	* configure.ac: Do not test for disable_dladdr.
	* configure: Regenerate.
Index: configure
===================================================================
--- configure	(revision 109804)
+++ configure	(working copy)
@@ -10127,19 +10127,14 @@
 echo "${ECHO_T}$ac_cv_lib_dl_dladdr" >&6
 if test $ac_cv_lib_dl_dladdr = yes; then
 
-     if test "x${disable_dladdr}" = "xyes"; then
-       #Broken dladdr().
-       true
-     else
 
 cat >>confdefs.h <<\_ACEOF
 #define HAVE_DLADDR 1
 _ACEOF
 
-     fi
-
 fi
 
+
    if test x"$build" = x"$host"; then
      echo "$as_me:$LINENO: checking for /proc/self/exe" >&5
 echo $ECHO_N "checking for /proc/self/exe... $ECHO_C" >&6
Index: configure.host
===================================================================
--- configure.host	(revision 109804)
+++ configure.host	(working copy)
@@ -28,8 +28,6 @@
 #			pthread_self calls by caching thread IDs in a hashtable
 #   can_unwind_signal   Set to "yes" if the EH unwinder supports throwing
 #			from a signal handler.
-#   disable_dladdr      Set to "yes" if dladdr should not be used
-#                       (i.e it is broken).
 #   fallback_backtrace_h  Header to use for fallback backtrace implementation
 #			  (only for targets that don't support DWARF2 unwind)
 #   descriptor_h	Header to use for looking past function descriptors
@@ -44,7 +42,6 @@
 sysdeps_dir=generic
 slow_pthread_self=
 can_unwind_signal=no
-disable_dladdr=
 fallback_backtrace_h=sysdep/generic/backtrace.h
 
 case "${target_optspace}:${host}" in
@@ -251,7 +248,6 @@
 	case "${host}" in
 	    mipsel*-linux* | mipsisa32el*-linux*)
 		enable_hash_synchronization_default=yes
-		disable_dladdr=yes
 	    ;;
 	esac
 	;;
Index: configure.ac
===================================================================
--- configure.ac	(revision 109804)
+++ configure.ac	(working copy)
@@ -930,13 +930,8 @@
    ])
 
    AC_CHECK_LIB(dl, dladdr, [
-     if test "x${disable_dladdr}" = "xyes"; then
-       #Broken dladdr().
-       true
-     else
-       AC_DEFINE(HAVE_DLADDR, 1, [Define if you have dladdr()])
-     fi
-   ])
+       AC_DEFINE(HAVE_DLADDR, 1, [Define if you have dladdr()])])
+
    if test x"$build" = x"$host"; then
      AC_CHECK_FILES(/proc/self/exe, [
        AC_DEFINE(HAVE_PROC_SELF_EXE, 1, [Define if you have /proc/self/exe])])

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]