This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: PATCH: java/25330: A race condition in write_classfile
- From: Andrew Haley <aph at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: "H. J. Lu" <hjl at lucon dot org>, gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
- Date: Mon, 12 Dec 2005 18:31:58 +0000
- Subject: Re: PATCH: java/25330: A race condition in write_classfile
- References: <20051210220307.GA3876@lucon.org> <m3fyoyrxpq.fsf@localhost.localdomain>
Tom Tromey writes:
> >>>>> "H.J." == H J Lu <hjl@lucon.org> writes:
>
> H.J.> With parallel build in libjava, several processes may want to generate
> H.J.> the same class file.
>
> When does this happen?
>
> It really shouldn't. gcj isn't eager like other java compilers -- it
> only compiles what you ask it to. We shouldn't have two invocations
> working on the same .java file.
And, indeed, that doesn't seem to be happening in the log for this PR.
There may be more to this than is apparent.
Having said that, it seems to me hj's patch is correct.
Andrew.