Re: Patch: RFA: Set default value for java.library.path

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Tom" == Thomas Fitzsimmons <fitzsim@redhat.com> writes:

Tom> With this patch the aclocal call used in gcc/libjava needs one
Tom> extra -I argument, becoming:
Tom> aclocal -I . -I .. -I ../config -I ./libltdl

You have to update the definition of ACLOCAL_AMFLAGS in
libjava/Makefile.am to reflect this.  But ...

Tom> The order of -I arguments to aclocal is important; misplacing
Tom> -I ./libltdl gives strange results.

Sounds like a clash between versions of macros.
Instead of doing it this way, I suggest extracting the appropriate
bits from libltdl/acinclude.m4 and putting them into a new .m4 file in
libjava/.  This isn't ideal as this file may need future maintenance,
but given that we update configure frequently compared to libltdl
(which we may not have ever updated), I think this is a better
approach.

In other respects the patch looks fine to me.

Tom