This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix PR23230 - wrong code generated in inner class


On 8/7/05, Robin Green <greenrd@greenrd.org> wrote:
> On Sun, Aug 07, 2005 at 10:36:34AM +0530, Ranjit Mathew wrote:
> >
> > Just to be sure, you did a *clean* build of libjava and then a testsuite
> > run with Jacks included, right?
> 
> Not quite. I did a clean build, yes, but Jacks was skipped in the testsuite
> (because it wasn't on the PATH I assume). However, I ran Jacks myself, and did
> "diff -u gcj.log.orig gcj.log". No changes. So I think that is OK.

These days, the only additional FAIL I see with Jacks on i686-pc-linux-gnu
is 3.10.2-round-6 (PR java/22113). So if you don't see any additional Jacks
failure, you should be OK.


> > Jacks is most likely not the place for such a testcase - AFAICT, they
> > only check for compilation success, error or warning.
> 
> That's not the case. There are runtime tests as well. It is a JLS test not a
> test of any specific API, so it should go in Jacks, I think - but I will
> double-check on that when I submit it.

Tom Tromey is usually the authority on such matters.


> > A better place
> > would be the libjava testsuite's "libjava.lang" sub-testsuite. A simple
> > testcase that reproduces the problem for me is:
> 
> Thanks! My patch works for this test case. Please could you grant me
> permission to submit a massaged version of that to Jacks under the GPL.

For such a trivial test case derived from your own test case in the PR,
this looks silly, but FWIW: please go ahead and merge it to every source
repository that would accept it. :-)

Ranjit.
-- 
Ranjit Mathew      Email: rmathew AT gmail DOT com

Bangalore, INDIA.    Web: http://ranjitmathew.hostingzero.com/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]