Re: [cp-patches] Re: Absolute URL parsing bug

[Mark Wielaard <mark at klomp dot org>]

Hi,

On Mon, 2005-07-04 at 18:07 +0100, Andrew Haley wrote: 
> When creating a URL: if the spec is absolute and a context URL is
> supplied, we should inherit the host:port part of the context if its
> protocol the same as that of the spec, but we should not inherit its
> file path.

Have you added the tests from your previous email to mauve?
There are a lot of URL tests in mauve, any new PASSes or FAILs?

> *************** public final class URL implements Serial
> *** 409,413 ****
>   	    host = context.host;
>   	    port = context.port;
> - 	    file = context.file;
>               userInfo = context.userInfo;
>   	    if (file == null || file.length() == 0)
> --- 409,412 ----

Isn't that last if statement now unnecessary?
It seems you can set file to "/" unconditionally here.

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part