This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/JDWP] Transport factory


>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> +    IllegalArgumentException e;
Keith> +    e = new IllegalArgumentException ("transport \"" + name + "\" not found");
Keith> +    throw new TransportException (e);

It is more ordinary to just make an IllegalArgumentException and throw
it.  Does this need to be caught somewhere else in the JDWP code
somehow?  If so, then wrapping an IllegalArgumentException seems a bit
weird...

Otherwise this looks fine.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]