This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [Patch] java.util.logging.LogManager
- From: Sven de Marothy <sven at physto dot se>
- To: Bryce McKinlay <mckinlay at redhat dot com>
- Cc: java-patches at gcc dot gnu dot org, classpath <classpath at gnu dot org>
- Date: Sat, 23 Apr 2005 18:20:48 +0200
- Subject: Re: [Patch] java.util.logging.LogManager
- References: <20050422045710.GA6134@asterix.konqueror.de> <42695006.5010500@redhat.com>
On Fri, 2005-04-22 at 15:27 -0400, Bryce McKinlay wrote:
> Firstly, please don't ever put formatting and code changes in the same
> patch! This is bad because it makes it difficult to distinguish code
> changes from changes that are purely reformatting.
Yes I know, sorry, that was an oversight on my part.
> Secondly, some of the formatting changes you made go against out
> established style. We break lines at 80-columns unless there is no way
> to cleanly do so. Also, 2-char indenting should be used for all methods,
> including "static" blocks.
Ok, to be honest I didn't look to closely at the result of formatting,
I'd just ran it through jalopy. So I'm not sure why that happened.
Apologies for the inconvenience.
/Sven