This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [Patch] java.util.logging.LogManager
- From: Michael Koch <konqueror at gmx dot de>
- To: Bryce McKinlay <mckinlay at redhat dot com>
- Cc: Sven de Marothy <sven at physto dot se>, classpath <classpath at gnu dot org>, java-patches at gcc dot gnu dot org
- Date: Fri, 22 Apr 2005 21:34:30 +0200
- Subject: Re: [Patch] java.util.logging.LogManager
- References: <20050422045710.GA6134@asterix.konqueror.de> <42695006.5010500@redhat.com>
On Fri, Apr 22, 2005 at 03:27:02PM -0400, Bryce McKinlay wrote:
> Michael Koch wrote:
>
> >Hi list,
> >I just commited the attached patch to merge it from GNU classpath to
> >HEAD to. It mainly reformates the LogManager.java file and fixes an
> >issue with logger keys.
> >Michael
> >2005-04-22 Sven de Marothy <sven@physto.se>
> >* java/util/logging/LogManager.java: Reformatted.
> >(readConfiguration): If a logger for a key is not found, create one.
> >
>
> Sven,
>
> Firstly, please don't ever put formatting and code changes in the same patch! This is bad because it
> makes it difficult to distinguish code changes from changes that are purely reformatting.
>
> Secondly, some of the formatting changes you made go against out established style. We break lines
> at 80-columns unless there is no way to cleanly do so. Also, 2-char indenting should be used for all
> methods, including "static" blocks.
Sorry, my fault, I should have reformatted before merging over.
Michael
--
Escape the Java Trap with GNU Classpath!
http://www.gnu.org/philosophy/java-trap.html
Join the community at http://planet.classpath.org/