Re: [RFC PATCH] Don't use ELF weak for entities with vague linkagewhen COMDAT groups are available

[Mark Mitchell <mark at codesourcery dot com>]

Eric Botcazou wrote:
> > > /usr/bin/ld: Warning: size of symbol
> > > `__gnu_cxx::__common_pool_policy<__gnu_cxx::__pool,
> > > true>::_S_destroy_thread_key(void*)' changed from 21 in testsuite_abi.o
> > > to 217 in testsuite_character.o
> > > /usr/bin/ld: Warning: size of symbol
> >
> > Would you check to see that these symbols are indeed in COMDAT groups in
> > both files?  If so, then the linker is being silly.  

> I guess the answer is positive.

It looks that way.  Would you happen to be able to try building the 
top-of-branch binutils 2.16 linker, and seeing whether it behaves this 
way as well?  If not, we can fix up the HAVE_GAS_COMDAT test to check 
for ld >= 2.16, or add a little test to see that we can object files 
with COMDAT without warnings.

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304