This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: RFA: fix declarations in gcc/java/decl.c
- From: Andrew Haley <aph at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>, Java Patch List <java-patches at gcc dot gnu dot org>
- Date: Fri, 1 Apr 2005 10:37:28 +0100
- Subject: Re: Patch: RFA: fix declarations in gcc/java/decl.c
- References: <m364z71due.fsf@localhost.localdomain>
Tom Tromey writes:
> I happened to notice that _Jv_MonitorEnter was declared incorrectly
> in decl.c -- the declaration there did not match what is in libgcj.
> Looking further I discovered a number of discrepancies.
>
> This patch cleans them up. We're still a bit careless about using
> ptr_type_node when something like class_type_node would be more
> accurate. I could do that, but it would be a bigger patch...
>
> I'm a little surprised things work as well as they seem to, given some
> of these bugs.
>
> Tested on trunk with x86 FC2. Ok? And ok for 4.0 after I apply and
> build/test there?
Yes, and yes! Thank you.
Andrew.
> Index: ChangeLog
> from Tom Tromey <tromey@redhat.com>
>
> * decl.c (java_init_decl_processing): Fix types of
> _Jv_MonitorEnter, _Jv_MonitorExit, _Jv_AllocObject,
> _Jv_AllocObjectNoFinalizer, _Jv_Throw, _Jv_NewPrimArray,
> _Jv_JNI_PopSystemFrame, _Jv_divI, _Jv_remI, _Jv_divJ, _Jv_remJ.