This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Fix PR libgcj/20389

David Daney wrote:

2005-03-09 David Daney <ddaney@avtrex.com>

    PR libgcj/20389
    Merge BufferedInputStream from GNU Classpath.
    * java/io/BufferedInputStream.java (marktarget): Field removed.
    (CHUNKSIZE): Field removed.
    (bufferSize): New field.
    (BufferedInputStream): Initialize fields.
    (close): Invalidate mark and buffer indexes.
    (mark):  Rewritten.
    (read()): Move mark handling code to refill.
    (read(byte[], int, int)): Ditto.
    (skip): Ditto and simplify EOF testing.
    (refill): Rewritten.
    * java/io/InputStreamReader.java (refill): Removed mark and reset
    of internal BufferedInputStream.

OK to commit to the 4.0 branch and mainline?




If you want to change the copyright line then it should go into Classpath as well. Also, it would be good to have a comment marking the divergance from classpath eg:

// GCJ LOCAL: package-private for use by InputStreamReader

OK for 4.0 and mainline with this change.



Committed to 4.0 with the 'GCJ LOCAL' comment added to refill.

Since I don't have Classpath write access I will let someone who does fix the copyright in BufferedInputStream if they desire.

On deck the mainline commit.

Committed to mainline.

David Daney

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]