This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Fix PR libgcj/20389


David Daney wrote:

BufferedInputStream.java from Classpath breaks InputStreamReader.java.

InputStreamReader.java from Classpath breaks because it needs gnu.java.io.decode.Decoder.

We either need to merge much of Classpath, or fix the existing BufferedInputStream.


The Encoder/Decoder mechanisms definitely need to be merged, and I believe this ie being worked on, but thats probably too much change for now.

The appropriate fix for InputStreamReader's dependence on BufferedInputStream will depend on the outcome of that merge.

The Classpath version looks plausible, but I would have to hack on it to make it fit with InputStreamReader.

Your call I guess.


That sounds ok - whatever results in the least diff's against classpath without changing things too radically for 4.0. Would making refill() package-private be sufficient?

Bryce


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]