This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC/RFT] Patch (java): Switch to new verifier


>>>>> "Ranjit" == Ranjit Mathew <rmathew@gmail.com> writes:

Ranjit> The attached patch proposes to switch GCJ to use the new
Ranjit> verifier.

I think this isn't safe, because vfy_is_assignable_from assumes that
we are generating type assertions.  With the C++ ABI, this is not the
case.

Also, I suspect that the new verifier generates typemaps that require
special treatment by subsequent code-generation passes.  There are
hacks in place for this, but I'm not sure they work when compiling
with the C++ ABI.

Ranjit> FWIW, the new verifier does seem a bit slower than
Ranjit> the old one, but it sure is a *lot* more comprehensive and
Ranjit> correct in a lot of cases.

I never did any performance tuning of it.  That would be
useful... feel like running it through a profiler?

It will be notably worse for code containing subroutines, due to the
way it handles jsr/ret.  I think that is basically unavoidable.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]