This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
[gcjx] Patch: FYI: two minor fixes
- From: Tom Tromey <tromey at redhat dot com>
- To: Java Patch List <java-patches at gcc dot gnu dot org>
- Date: 19 Feb 2005 11:11:37 -0700
- Subject: [gcjx] Patch: FYI: two minor fixes
- Reply-to: tromey at redhat dot com
I'm checking this in on the gcjx branch.
This removes an assertion that was firing erroneously; this is a
temporary fix, as I think the real fix is elsewhere.
This also adds a virtual destructor where I had forgotten to put one.
Tom
Index: ChangeLog
from Tom Tromey <tromey@redhat.com>
* compiler.cc (find_class): Removed assertion.
* visitor.hh (~visitor): New virtual destructor.
Index: compiler.cc
===================================================================
RCS file: /cvs/gcc/gcc/gcjx/Attic/compiler.cc,v
retrieving revision 1.1.2.4
diff -u -r1.1.2.4 compiler.cc
--- compiler.cc 13 Feb 2005 03:39:44 -0000 1.1.2.4
+++ compiler.cc 19 Feb 2005 18:10:34 -0000
@@ -188,7 +188,10 @@
model_class *
compiler::find_class (const std::list<std::string> &name)
{
- assert (state > PARSING_FILES);
+ // FIXME: this is called by classify_package_name, which is called
+ // by the parsers. Probably they should call some new function to
+ // force creation of a package.
+ // assert (state > PARSING_FILES);
Iname *obj = find_name (name);
if (obj == NULL)
{
Index: visitor.hh
===================================================================
RCS file: /cvs/gcc/gcc/gcjx/Attic/visitor.hh,v
retrieving revision 1.1.2.1
diff -u -r1.1.2.1 visitor.hh
--- visitor.hh 13 Jan 2005 03:18:33 -0000 1.1.2.1
+++ visitor.hh 19 Feb 2005 18:10:34 -0000
@@ -1,6 +1,6 @@
// Walking the model.
-// Copyright (C) 2004 Free Software Foundation, Inc.
+// Copyright (C) 2004, 2005 Free Software Foundation, Inc.
//
// This file is part of GCC.
//
@@ -26,6 +26,10 @@
{
public:
+ virtual ~visitor ()
+ {
+ }
+
virtual void visit_method (model_method *,
const std::list<ref_variable_decl> &,
const ref_block &) = 0;