This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [cp-patches] [Patch][gui] javax.swing.JTree
- From: Michael Koch <konqueror at gmx dot de>
- To: Mark Wielaard <mark at klomp dot org>
- Cc: java-patches at gcc dot gnu dot org, Classpath patch list <classpath-patches at gnu dot org>
- Date: Sat, 1 Jan 2005 17:28:02 +0100
- Subject: Re: [cp-patches] [Patch][gui] javax.swing.JTree
- References: <20041231163508.GA13351@asterix.konqueror.de> <1104594466.30641.236.camel@localhost.localdomain>
Am Samstag, 1. Januar 2005 16:47 schrieb Mark Wielaard:
> Hi,
>
> > 2004-12-31 Michael Koch <konqueror@gmx.de>
> >
> > * javax/swing/JTree.java
> > (hasChildren): New instance field.
>
> I assume this is DynamicUtilTreeNode.hasChildren. Try to mention
> the inner class if you change one.
Damn, you are right.
> > + /**
> > + * XXX: Currently not implemented.
> > + */
> > + protected boolean hasChildren;
>
> Eh. What does it? If it isn't implemented, why do we have a dummy
> field? (no more stubs!) Could you at least document that it always
> returns false.
Its no stub. Its this way intentional. In our implementation it always
returns false but even this is not guaranteed as this field is not
used according to SUNs javadocs. The problem is that 2rd party
software might use it already. But they have to take care about the
value of the field themself.
Michael
--
Homepage: http://www.worldforge.org/