This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gui] Implement accessibility for menu classes


Am Mittwoch, 29. Dezember 2004 18:23 schrieb Jerry Quinn:
> Michael Koch wrote:
> > Am Mittwoch, 29. Dezember 2004 00:53 schrieb Jerry Quinn:
> >>+    /* Create the context if this is the first request */
> >>+    if (accessibleContext == null)
> >>+      {
> >>+        /* Create the context */
> >>+        accessibleContext = new AccessibleAWTCheckboxMenuItem();
> >>+      }
> >>+    return accessibleContext;
> >
> > Don't you think the code speaks enough without comments in this
> > case ? Comments are useful but too many comments can obscure code
> > more then needed.
>
> Can I pin the blame on copy and paste?

Well, the comments are mostly user(coder)-preference. I just thought 
the code is clear enough in this case without comments.

Commit if you like. I don't wanna bother your. You do great work.


Michael
-- 
Homepage: http://www.worldforge.org/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]