This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] merge/import X509 certificate code from Classpath


Hi Bryce,

Bryce McKinlay wrote:

2004-11-15 Andreas Tobler <a.tobler@schweiz.ch>

Import/Merge the X.509 certificate code from Classpath.

    * Makefile.am: Add imported files.
    * Makefile.in: Regenerate.

2004-11-07 Casey Marshall <csm@gnu.org>

    * gnu/java/security/provider/Gnu.java(<init>): Add entries in a
    priviliged action. Add new algorithms.


Andreas,


This looks good, thanks. I'm not entirely sure that the use of static references to force the providers to be linked in when compiling statically is a good idea, however, we've done this elsewhere and you've flagged it with a comment so I think its ok for now. I don't think they will hurt if we, eventually, come up with a better static linking solution.

My work is basically fetch the classpath cvs diff of the corresponding patch, apply it to the libgcj and adjust the Makefile.am if necessary.
So the core work is still done by the classpath patch originator. In this case by Casey.


My goal is to get only a minimal diff between CP and libgcj, I do not change anything in the patch unless I see it is necessary.

So the flagging you mention above was done by Casey. And I'm only the worker doing the merge part :) (P.S, I do not want to blame anyone, I just want to clarify that the credits do not go to me)

If still ok I'll commit soon.

Thanks,
Andreas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]