This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gui] ToolTipManager.mouseMoved()


Hi,

On Fri, 2004-11-12 at 23:08, Mark Wielaard wrote:
> Does this patch make sense, or should currentComponent never be null
> when mouseMoved() is called?
> 
> 2004-11-12  Mark Wielaard  <mark@klomp.org>
> 
>         * javax/swing/ToolTipManager.java (mouseMoved): Set currentComponent
>         when not yet set.
> 
> I get NullPointerExceptions in jfreechart without this.

On irc Graydon said to commit this if it improved the situation for me.
So I did (GNU Classpath CVS and gui branch).

Cheers,

Mark

________________________________________________________________________
> Index: javax/swing/ToolTipManager.java
> ===================================================================
> RCS file: /cvsroot/classpath/classpath/javax/swing/ToolTipManager.java,v
> retrieving revision 1.8
> diff -u -r1.8 ToolTipManager.java
> --- javax/swing/ToolTipManager.java	11 Nov 2004 17:22:52 -0000	1.8
> +++ javax/swing/ToolTipManager.java	12 Nov 2004 22:08:18 -0000
> @@ -452,7 +452,13 @@
>    {
>      currentPoint = event.getPoint();
>      if (currentTip != null)
> -      currentTip.setTipText(((JComponent) currentComponent).getToolTipText(event));
> +      {
> +	if (currentComponent == null)
> +	  currentComponent = (Component) event.getSource();
> +	
> +	String text = ((JComponent) currentComponent).getToolTipText(event);
> +	currentTip.setTipText(text);
> +      }
>      if (enterTimer.isRunning())
>        enterTimer.restart();
>    }

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]