This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] buglets in file locking
- From: Casey Marshall <csm at gnu dot org>
- To: Bryce McKinlay <mckinlay at redhat dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: Fri, 12 Nov 2004 10:57:46 -0800
- Subject: Re: [PATCH] buglets in file locking
- References: <87r7mz4n3x.fsf@gnu.org> <4194E601.1000102@redhat.com>
>>>>> "Bryce" == Bryce McKinlay <mckinlay@redhat.com> writes:
Bryce> Hi Casey,
Bryce> Casey Marshall wrote:
>> Hi,
>>
>> This patch fixes a couple of buglets in the FileLock implementation
>> in libgcj. Both were flipped meanings, one that a file lock is
>> valid only while the associated channel is open, and another that a
>> shared lock maps to F_RDLCK. The original implementation assumed
>> the opposite.
>>
>> 2004-11-11 Casey Marshall <csm@gnu.org>
>>
>> * gnu/java/nio/FileLock.java (isValid): locks are valid if the
>> channel is open.
>> * gnu/java/nio/channels/natFileChannelPosix.cc (lock): use
>> 'F_RDLCK' for shared locks, 'F_WRLCK' for exclusive locks.
>>
Bryce> Looks good. Please check this in. Thanks!
I don't have write access.
--
Casey Marshall || csm@gnu.org