RE: [PATCH] boehm gc support for CRIS

["Boehm, Hans" <hans dot boehm at hp dot com>]

The GC patch was already sent to me earlier.  My apologies for being
slow.

It mostly looks good to me.  Thanks.  I do have a couple of concerns about the
test_and_set implementation:

- Can we identify the original author of the GC_test_and_set code,
and get his/her OK?  Is it Ulrich Drepper?  The collector distribution
itself falls under an MIT style license, and linuxthreads is LGPL, if
I understand correctly?  There is sufficiently little code that I'm
not sure we absolutely need permission, but I'd like to be sure,
and get it.  (I'd also like to carry this forward to gc7.0 by
putting similar code in the atomic_ops package.  The atomic instruction
support in the GC itself is going away.)

- Is it possible to add a comment how this works?  It looks like this
assumes a uniprocessor (probably safe for now), and tests a flag which
is set on context switch?  Am I reading that correctly?

Hans

> -----Original Message-----
> From: tromey@redhat.com [mailto:tromey@redhat.com]
> Sent: Wednesday, October 27, 2004 12:17 PM
> To: Ranjit Mathew
> Cc: Simon Posnjak; GCC Patches; Boehm, Hans; green@redhat.com; GCJ
> Patches
> Subject: Re: [PATCH] boehm gc support for CRIS
> 
> 
> >>>>> "Ranjit" == Ranjit Mathew <rmathew@gmail.com> writes:
> 
> >> This patch adds support for CRIS platform to Boehm GC.
> 
> Ranjit> Since both Boehm GC and libffi are used primarily by
> Ranjit> Java within GCC, IMHO you should CC
> Ranjit> java-patches@gcc.gnu.org too for these patches.
> 
> Ranjit> For Boehm GC, it'd be nice to synchronise with upstream
> Ranjit> too and hence you should CC Hans Boehm too.
> 
> Ranjit> AFAICT, Anthony Green is the maintainer for libffi, so
> Ranjit> probably he should be CC-ed too.
> 
> Generally the way this works is that Hans accepts or rejects most GC
> patches.  Exceptions are small portability and configury fixes, which
> we commit more freely (and send to him for possible inclusion
> upstream).
> 
> For libffi, configury and other such improvements can be approved by a
> number of people.  Andreas Tobler maintains the libffi test suite.
> Port-specific libffi changes are ordinarily reviewed by the port
> maintainer, since usually these changes need a lot of knowledge about
> the particular ABI.
> 
> This process is probably inadequately documented.
> 
> Tom
>