This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[patch] [gui] warning patrol no 2 gtk-peer stuff

From: Andreas Tobler <toa at pop dot agri dot ch>
To: Java Patches <java-patches at gcc dot gnu dot org>
Date: Thu, 21 Oct 2004 22:19:54 +0200
Subject: [patch] [gui] warning patrol no 2 gtk-peer stuff

Hi again,

the next bunch.

A few things are obvious, others not. Please review.

Thanks,
Andreas

2004-10-21 Andreas Tobler <a.tobler@schweiz.ch>

	* jni/gtk-peer/gnu_java_awt_peer_gtk_GtkTextAreaPeer.c
	(Java_gnu_java_awt_peer_gtk_GtkTextAreaPeer_create): Cast the right way.

	* jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c
	(connect_awt_hook_cb): Mark unused variable unused.

	* jni/gtk-peer/gnu_java_awt_peer_gtk_GtkClipboard.c (selection_get):
	Do the cast right.

	* jni/gtk-peer/gnu_java_awt_peer_gtk_GtkChoicePeer.c
	(Java_gnu_java_awt_peer_gtk_GtkChoicePeer_create): According to
	the gtk API gtk_combo_box_new_text actually returns a GtkWidget.
	Remove unused var menu.
	(selection_changed): Remove unused value.

	* jni/gtk-peer/gnu_java_awt_peer_gtk_GtkButtonPeer.c
	(Java_gnu_java_awt_peer_gtk_GtkButtonPeer_setNativeBounds): Fix pointer
	warning.

	* jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c
	(area_updated): Fix unused var warning for BE archs.

	* jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics.c
	(Java_gnu_java_awt_peer_gtk_GdkGraphics_connectSignals): Remove unused
	var.
	(realize_cb): Mark unused variable unused.

	* jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGlyphVector.c
	(seek_glyphstring_idx): Fix a C90 warning

Index: jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGlyphVector.c
===================================================================
RCS file: /cvs/gcc/gcc/libjava/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGlyphVector.c,v
retrieving revision 1.2.12.4
diff -u -r1.2.12.4 gnu_java_awt_peer_gtk_GdkGlyphVector.c
--- jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGlyphVector.c	9 Oct 2004 08:15:44 -0000	1.2.12.4
+++ jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGlyphVector.c	21 Oct 2004 20:14:31 -0000
@@ -114,12 +114,13 @@
 {
   GList *i = NULL;
   PangoGlyphItem *gi = NULL;
+  int begin = 0;
 
   g_assert (list != NULL);
   g_assert (gs != NULL);
   g_assert (nidx != NULL);
 
-  int begin = 0;
+ 
   for (i = g_list_first (list); i != NULL; i = g_list_next (i))
     {
       g_assert (i->data != NULL);
Index: jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics.c
===================================================================
RCS file: /cvs/gcc/gcc/libjava/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics.c,v
retrieving revision 1.5.2.10
diff -u -r1.5.2.10 gnu_java_awt_peer_gtk_GdkGraphics.c
--- jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics.c	8 Oct 2004 17:44:58 -0000	1.5.2.10
+++ jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics.c	21 Oct 2004 20:14:31 -0000
@@ -130,7 +130,6 @@
   (JNIEnv *env, jobject obj, jobject peer)
 {
   void *ptr;
-  jobject *gref;
 
   ptr = NSA_GET_PTR (env, peer);
 
@@ -642,7 +641,8 @@
   gdk_threads_leave ();
 }
 
-static void realize_cb (GtkWidget *widget, jobject peer)
+static void realize_cb (GtkWidget *widget __attribute__ ((unused)), 
+			jobject peer)
 {
   gdk_threads_leave ();
 
Index: jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c
===================================================================
RCS file: /cvs/gcc/gcc/libjava/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c,v
retrieving revision 1.2.10.4
diff -u -r1.2.10.4 gnu_java_awt_peer_gtk_GdkPixbufDecoder.c
--- jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c	23 Sep 2004 08:34:12 -0000	1.2.10.4
+++ jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c	21 Oct 2004 20:14:32 -0000
@@ -99,14 +99,17 @@
   JNIEnv *env;
   union env_union e;
   jint stride_bytes, stride_pixels, n_channels, n_pixels;
-  int i;
   jintArray jpixels;  
   jint *java_pixels;
   guchar *gdk_pixels;
 
   GdkPixbuf *pixbuf_no_alpha = NULL;
   GdkPixbuf *pixbuf = NULL;
-  
+
+#ifndef WORDS_BIGENDIAN
+  int i;
+#endif
+
   pixbuf_no_alpha = gdk_pixbuf_loader_get_pixbuf (loader);
   if (pixbuf_no_alpha == NULL)
     return;
Index: jni/gtk-peer/gnu_java_awt_peer_gtk_GtkButtonPeer.c
===================================================================
RCS file: /cvs/gcc/gcc/libjava/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkButtonPeer.c,v
retrieving revision 1.8.2.8
diff -u -r1.8.2.8 gnu_java_awt_peer_gtk_GtkButtonPeer.c
--- jni/gtk-peer/gnu_java_awt_peer_gtk_GtkButtonPeer.c	13 Oct 2004 18:49:46 -0000	1.8.2.8
+++ jni/gtk-peer/gnu_java_awt_peer_gtk_GtkButtonPeer.c	21 Oct 2004 20:14:32 -0000
@@ -301,8 +301,7 @@
       gtk_widget_set_size_request (gtk_bin_get_child (GTK_BIN (widget)),
                                    width, height);
       /* ...and the label's size request. */
-      gtk_widget_set_size_request (gtk_bin_get_child (gtk_bin_get_child (GTK_BIN (widget))),
-                                                      width, height);
+      gtk_widget_set_size_request (gtk_bin_get_child (GTK_BIN (gtk_bin_get_child (GTK_BIN (widget)))), width, height);
       if (widget->parent != NULL)
         gtk_fixed_move (GTK_FIXED (widget->parent), widget, x, y);
     }
Index: jni/gtk-peer/gnu_java_awt_peer_gtk_GtkChoicePeer.c
===================================================================
RCS file: /cvs/gcc/gcc/libjava/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkChoicePeer.c,v
retrieving revision 1.6.8.3
diff -u -r1.6.8.3 gnu_java_awt_peer_gtk_GtkChoicePeer.c
--- jni/gtk-peer/gnu_java_awt_peer_gtk_GtkChoicePeer.c	30 Jul 2004 09:47:58 -0000	1.6.8.3
+++ jni/gtk-peer/gnu_java_awt_peer_gtk_GtkChoicePeer.c	21 Oct 2004 20:14:32 -0000
@@ -45,8 +45,7 @@
 Java_gnu_java_awt_peer_gtk_GtkChoicePeer_create 
   (JNIEnv *env, jobject obj)
 {
-  GtkWidget *menu;
-  GtkComboBox *combobox;
+  GtkWidget *combobox;
 
   NSA_SET_GLOBAL_REF (env, obj);
 
@@ -181,7 +180,6 @@
   jstring label;
   GtkTreeModel *model;
   GtkTreeIter iter;
-  GValue value;
   gchar *selected;
   gint index;
 
Index: jni/gtk-peer/gnu_java_awt_peer_gtk_GtkClipboard.c
===================================================================
RCS file: /cvs/gcc/gcc/libjava/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkClipboard.c,v
retrieving revision 1.3
diff -u -r1.3 gnu_java_awt_peer_gtk_GtkClipboard.c
--- jni/gtk-peer/gnu_java_awt_peer_gtk_GtkClipboard.c	11 Dec 2003 13:50:51 -0000	1.3
+++ jni/gtk-peer/gnu_java_awt_peer_gtk_GtkClipboard.c	21 Oct 2004 20:14:32 -0000
@@ -149,7 +149,7 @@
   utf = (*gdk_env)->GetStringUTFChars (gdk_env, jstr, NULL);
 
   gtk_selection_data_set (selection_data, GDK_TARGET_STRING, 8, 
-			  (char *)utf, utflen);
+			  (unsigned char*)utf, utflen);
 
   (*gdk_env)->ReleaseStringUTFChars (gdk_env, jstr, utf);
 }
Index: jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c
===================================================================
RCS file: /cvs/gcc/gcc/libjava/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c,v
retrieving revision 1.19.2.12
diff -u -r1.19.2.12 gnu_java_awt_peer_gtk_GtkEvents.c
--- jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c	7 Oct 2004 22:11:59 -0000	1.19.2.12
+++ jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c	21 Oct 2004 20:14:33 -0000
@@ -1128,7 +1128,8 @@
  * can be sure that widget->window is non-NULL, and so can have data
  * connected to it.
  */
-void connect_awt_hook_cb (GtkWidget *widget, jobject peer)
+void connect_awt_hook_cb (GtkWidget *widget __attribute__((unused)),
+			  jobject peer)
 {
   void *ptr;
 
Index: jni/gtk-peer/gnu_java_awt_peer_gtk_GtkTextAreaPeer.c
===================================================================
RCS file: /cvs/gcc/gcc/libjava/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkTextAreaPeer.c,v
retrieving revision 1.11.8.6
diff -u -r1.11.8.6 gnu_java_awt_peer_gtk_GtkTextAreaPeer.c
--- jni/gtk-peer/gnu_java_awt_peer_gtk_GtkTextAreaPeer.c	2 Sep 2004 21:26:26 -0000	1.11.8.6
+++ jni/gtk-peer/gnu_java_awt_peer_gtk_GtkTextAreaPeer.c	21 Oct 2004 20:14:34 -0000
@@ -54,7 +54,7 @@
 
   text = gtk_text_view_new ();
   gtk_widget_set_size_request (text, textview_width, textview_height);
-  gtk_text_view_set_cursor_visible(text, TRUE);
+  gtk_text_view_set_cursor_visible((GtkTextView*)text, TRUE);
 
   gtk_widget_show (text);

Follow-Ups:
- Re: [patch] [gui] warning patrol no 2 gtk-peer stuff
  - From: Thomas Fitzsimmons
- Re: [patch] [gui] warning patrol no 2 gtk-peer stuff
  - From: Mark Wielaard

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]