This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH/RFA] libffi: A SH fixup and a new testcase

From: Andreas Tobler <toa at pop dot agri dot ch>
To: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
Cc: Andrew Haley <aph at redhat dot com>, java-patches at gcc dot gnu dot org, green at redhat dot com, andreast at gcc dot gnu dot org
Date: Thu, 21 Oct 2004 07:37:32 +0200
Subject: Re: [PATCH/RFA] libffi: A SH fixup and a new testcase
References: <20041021.093304.43018791.kkojima@rr.iij4u.or.jp>

Kaz Kojima wrote:

Hi,
SH's ffi_call_SYSV wrongly assumes that the double arguments were
aligned on stack by ffi_prep_args.  This bug causes a few failures
of libjava tests with gij on SH.  The appended patch fixes it and
adds a new test for it because this bug couldn't be caught with
the existing libffi tests.  The result of make check is:
=== libffi Summary ===
# of expected passes		216
# of unsupported tests		2
I've checked that the new test passes also on i686-pc-linux-gnu.
OK for mainline?
FYI, with this and SH custom java-signal.h patch waiting for review

http://gcc.gnu.org/ml/gcc-patches/2004-10/msg01327.html

there are no failures in libjava test on sh4-unknown-linux-gnu.

Cool, the test case is fine. Thanks for providing one!

The signal stuff needs some attention from aph or bryce?

Regards,
Andreas

References:
- [PATCH/RFA] libffi: A SH fixup and a new testcase
  - From: Kaz Kojima

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]