This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: C++ PATCH: 14035
- From: Andrew Haley <aph at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Andreas Schwab <schwab at suse dot de>, java-patches at gcc dot gnu dot org
- Date: Wed, 20 Oct 2004 18:11:12 +0100
- Subject: Re: C++ PATCH: 14035
- References: <200410192329.i9JNTEcX022990@sirius.codesourcery.com><jemzyho8k2.fsf@sykes.suse.de><m3oeixz5ai.fsf@localhost.localdomain>
Tom Tromey writes:
> >>>>> "Andreas" == Andreas Schwab <schwab@suse.de> writes:
>
> Andreas> The casts to int should probably be changed to casts to
> Andreas> uaddr. I'm testing this patch now:
>
> This is ok, just one minor nit.
>
> Andreas> + _Jv_Utf8Const *name = klass->constants.data[(uaddr)superclass].utf8;
>
> Space after the cast please.
Uh, really? Is this some convention I don't know about?
Andrew.