Re: [patch] minimal test case for sha-1 and md5

[Andrew Haley <aph at redhat dot com>]

David Daney writes:
 > Andrew Haley wrote:
 > > Tom Tromey writes:
 > >  > >>>>> "Andreas" == Andreas Tobler <toa@pop.agri.ch> writes:
 > >  > 
 > >  > Andreas> My motivation with these two tests was simply not to forget a
 > >  > Andreas> test, we need every single test even if they are small. And
 > >  > Andreas> they would have shown us in gcc world that something has been
 > >  > Andreas> broken.
 > >  > 
 > >  > Often one of us has to rewrite a test case into Mauve form.
 > >  > Library tests really belong in Mauve, not libgcj.  That way they can
 > >  > be shared among all Classpath users.
 > > 
 > > In this particular case, I want message digest tests in the libgcj
 > > testsuite because they test important system components and are also
 > > an excellent test of the compiler.  Everyone who builds gcc and runs
 > > "make check" gets to run these tests, rather than the three people in
 > > the world who routinely run Mauve.
 > 
 > Should we create another testsuite directory (say libjava.other) and put
 > the tests in there?  To me libjava.lang implies tests related to
 > java.lang.**, and to date it seems that most of the tests there only test
 > things in the java.lang packages.

I accept that point: perhaps it should be in libjava.security.
However, the important point is that it should be there.

Andrew.