This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch] mauve testsuite sql Timestamp


Hi all,

there is a bug in the mauve/gnu/testlet/java/sql/Timestamp test.

Doing this in a tclsh gives me the following:

% set time_c [clock format 1099999999 -format "%Y-%m-%d %H:%M:%S"]
2004-11-09 12:33:19

In the test we have a time of 06:33:19. So the equals always fails for toString.

with the attached patch I get:

[wolfram:libjava/testsuite/mauve-build] andreast% ./DejaGNUTestHarness run gnu.testlet.java.sql.Timestamp.TimestampTest
PASS: gnu.testlet.java.sql.Timestamp.TimestampTest: valueOf (number 1)
PASS: gnu.testlet.java.sql.Timestamp.TimestampTest: getNanos (number 1)
PASS: gnu.testlet.java.sql.Timestamp.TimestampTest: toString (number 1)
PASS: gnu.testlet.java.sql.Timestamp.TimestampTest: getNanos (number 1)
PASS: gnu.testlet.java.sql.Timestamp.TimestampTest: toString (number 1)
PASS: gnu.testlet.java.sql.Timestamp.TimestampTest: getNanos (number 1)
PASS: gnu.testlet.java.sql.Timestamp.TimestampTest: toString (number 1)
PASS: gnu.testlet.java.sql.Timestamp.TimestampTest: equals (number 1)
PASS: gnu.testlet.java.sql.Timestamp.TimestampTest: equals (number 1)
0 of 9 tests failed


Otherwise I had three failures, see gcc-results.


Could anyone familar with mauve and cvs please check and if ok commit ?


Andreas

Index: gnu/testlet/java/sql/Timestamp/TimestampTest.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/sql/Timestamp/TimestampTest.java,v
retrieving revision 1.2
diff -u -r1.2 TimestampTest.java
--- gnu/testlet/java/sql/Timestamp/TimestampTest.java 15 Jul 2004 20:58:41 -0000 1.2
+++ gnu/testlet/java/sql/Timestamp/TimestampTest.java 9 Oct 2004 20:29:18 -0000
@@ -42,17 +42,17 @@


     Timestamp ts = new Timestamp(1099999999333L);
     harness.check(ts.getNanos() == 333000000, "getNanos");
-    harness.check(ts.toString().equals("2004-11-09 06:33:19.333"),
+    harness.check(ts.toString().equals("2004-11-09 12:33:19.333"),
                   "toString");

     ts.setNanos(42);
     harness.check(ts.getNanos() == 42, "getNanos");
-    harness.check(ts.toString().equals("2004-11-09 06:33:19.000000042"),
+    harness.check(ts.toString().equals("2004-11-09 12:33:19.000000042"),
                   "toString");

     ts.setNanos(0);
     harness.check(ts.getNanos() == 0, "getNanos");
-    harness.check(ts.toString().equals("2004-11-09 06:33:19.0"),
+    harness.check(ts.toString().equals("2004-11-09 12:33:19.0"),
                   "toString");

Timestamp ts2 = new Timestamp(1099999999999L);


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]