This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] Fix PACKAGE_* redefined warnings in libjava.
- From: Kelley Cook <kcook at gcc dot gnu dot org>
- To: Bryce McKinlay <mckinlay at redhat dot com>
- Cc: GCJ-patches <java-patches at gcc dot gnu dot org>, Hans Boehm <Hans dot Boehm at hp dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Christian Joensson <christian at j-son dot org>
- Date: Thu, 7 Oct 2004 11:59:37 -0700 (PDT)
- Subject: Re: [PATCH] Fix PACKAGE_* redefined warnings in libjava.
- Reply-to: kcook at gcc dot gnu dot org
--- Bryce McKinlay <mckinlay@redhat.com> wrote:
> Kelly,
>
> Just FYI: "gc_config.h" was introduced partly to avoid the PACKAGE_*
> redefinition warnings. gc_config.h.in was deliberately not
> autoheader-generated, so that it only exported a few symbols that
> needed
> to be "public" ie visibile to clients outside the GC - ie libjava. Is
> there any reason why gc_config.h.in must be an autoheader generated
> file?
Of course it isn't a "must" to autogenerate gc_config.h.in, hence
option 1) which revert the previous patch.
On the otherhand, installing this patch lets autoreconf work again and
reduces the chance that a particular AC_DEFINE is added to configure.ac
or *.m4, but not to the corresponding gc_config.h.in.
I really don't feel strongly one way or the other. Since, I caused the
problem, I suggested two options to fix it.
KC