This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gui] Add IndexColorModel methods

Tom Tromey wrote:
"Jerry" == Jerry Quinn <jlquinn@optonline.net> writes:


Jerry> + private BigInteger validBits = new BigInteger("0");

I didn't really look through this code... would it be better to use a
BitSet here?

The API docs actually require a BigInteger to be returned for validBits. So we could keep a bitset internally and construct a BigInteger when needed. One thing from sun's docs that isn't clear is if a client calls validBits() and changes a bit, is the model supposed to pick up that change?

Jerry

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]