This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix CLASSPATH separator on MinGW.


Hi Aaron,

>I don't have the exact error message on hand, but when the libjava build
>started, gcj wasn't able to find anything in CLASSPATH, and so the
>libjava build failed on the first Java source file.  This is because,
>for i686-pc-mingw32, only a semicolon is recognized as a separator, and
>so gcj just parses one big, invalid path.  This happens because
>PATH_SEPARATOR is set, correctly, to a semicolon on MinGW.

Thanks for clarifying this. I think the approach is okay, but defer further
commentary to the higher-ups.

>OK.  I'm not entirely sure that regression testing is necessary;
>building should be sufficient, as if this patch broke something, the
>build would fail.  If the build doesn't fail, then I don't see how
>anything could be wrong on account of this.

I agree in theory, but I've seen weirder things before. In any case, I
can the tests.

>I put the MinGW tools in front of the Cygwin tools in PATH and supply a
>custom Windows ln, and everything works just peachily.

Don't you have to muck around with the Cygwin mounts too?

-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]