Re: Please post real patches (Was: [gui][patch] fix jcomponent action reset)

[Michael Koch <konqueror at gmx dot de>]

On Monday 06 September 2004 22:19, Mark Wielaard wrote:
> Hi,
>
> On Mon, 2004-09-06 at 12:08, Andrew Haley wrote:
> > As maintainer, you have the right to demand patches in any
> > reasonable form, and it's important for us to reduce the load on
> > you.  So, you will get what you want.
>
> I can handle patches in other formats if those other formats are
> really better for other situations. The reason I reacted so
> strongly was that after I applied a lot of patches I found out that
> there was still a huge diff between GNU Classpath and the gcj gui
> branch:
> http://gcc.gnu.org/java/gui-compare/libgcj-classpath-compare.html
> More than 50% of that is whitespace differences...
> I should have realized my mistake of just trusting the patches send
> to the list earlier.
>
> So lets agree to at least explicitly mention the fact that a patch
> is not in a format that can be readily applied to the tree. And
> lets discourage posting such diffs if it isn't strictly necessary
> to make code review easier.

As we discussed earlier on irc I still think "readable" patches on the 
mailinglist are better then "real" patches for code review. The 
"real" patch can be get easily via "cvs diff" if needed.

/me hides when Marks strong arm wants to catch him.


Michael