This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: java.io.File
- From: Michael Koch <konqueror at gmx dot de>
- To: java-patches at gcc dot gnu dot org
- Cc: Bryce McKinlay <mckinlay at redhat dot com>, jeroen at frijters dot net
- Date: Sun, 5 Sep 2004 07:46:52 +0200
- Subject: Re: Patch: java.io.File
- References: <200409042126.16670.konqueror@gmx.de> <413A4007.6030500@redhat.com>
On Sunday 05 September 2004 00:21, Bryce McKinlay wrote:
> Michael Koch wrote:
> >I wrote/megred the attached patch to merge more with classpath'
> >version of java.io.File. Mauve testsuite run with no new
> > regressions.
> >
> >Ok for trunk ?
> >
> >
> >Michael
> >
> >
> >2004-09-04 Jeroen Frijters <jeroen@frijters.net>
> >
> > (normalizePath): Added special case for windows systems.
> >
> >2004-09-04 Michael Koch <konqueror@gmx.de>
> >
> > * java/io/File.java
> > (dupSeparator): Made private.
> > (File(URI)): New constructor.
> > (getParentFile): Fixed javadoc.
> > (createTempFile): Reformated.
> > (setReadOnly): Added comment.
> > (deleteOnExit): Merged javadoc with classpath version.
>
> OK....
>
> >+ ((p.charAt(1) >= 'a' && p.charAt(1) <= 'z') ||
> >+ (p.charAt(1) >= 'A' && p.charAt(1) <= 'Z')) &&
>
> ... but I wonder if these tests are neccessary. It's probably
>
> sufficient, and faster, to just test this:
> >+ p.charAt(2) == ':')
Didnt some Windows NT supported drive names like 'AA', 'AB', 'AC' ...
'ZZ' ? i don't know for sure but I think I read this somewhere.
Michael