This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
"Andreas" == Andreas Tobler <toa@pop.agri.ch> writes:
Sounds good. Just one nit...
Andreas> + if {[catch {exec tclsh$tcl_ver jacks gcj} msg]} { Andreas> + send_log "Couldn't run jacks: $msg\n" Andreas> + return
I think the exec will always fail, since we don't pass all the tests. So the `return' is misplaced and perhaps the send_log message could be reworded a little.
Thanks, Andreas
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |